Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 update candlestick chart every 1 sec on mobile as workaround to optimize the clicking on trading page #1470

Merged
merged 2 commits into from
Dec 5, 2023
Merged

refactor: 💡 update candlestick chart every 1 sec on mobile as workaround to optimize the clicking on trading page #1470

merged 2 commits into from
Dec 5, 2023

Conversation

arealclimber
Copy link
Member

DEVELOP

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber
refactor: 💡 update candlestick chart every 1 sec on mobile as
9efa6d0 
workaround to optimize the clicking on trading page

✅ Closes: #1041
@arealclimber arealclimber added this to the v0.8.0 Alpha milestone Dec 1, 2023
@arealclimber arealclimber self-assigned this Dec 1, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 9:02am

@arealclimber arealclimber linked an issue Dec 1, 2023 that may be closed by this pull request
CandlestickChart 效能優化 #1041
Closed
Luphia
Luphia approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit c9c381a into develop Dec 5, 2023
2 of 8 checks passed
@Luphia Luphia deleted the refactor/workaround-mobile-click branch December 5, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

CandlestickChart 效能優化
2 participants
@arealclimber @Luphia