Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/lighthouse enhancement #1478

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Feature/lighthouse enhancement #1478

merged 6 commits into from
Dec 18, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Dec 7, 2023 •
edited
Loading

DEVELOP

  • Cta
  • Hero
  • HeroReverse
  • ReserveRatio
  • AuditReport
  • AppDowloadContainer

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • high risk: 0
  • new sql: 0

UML

@Julian0701 Julian0701 self-assigned this Dec 7, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 9:38am

@Julian0701 Julian0701 linked an issue Dec 7, 2023 that may be closed by this pull request
根據 Lighthouse 指標優化 TBD (1/2) #1435
Closed
@Julian0701 Julian0701 marked this pull request as draft December 8, 2023 01:30
Base automatically changed from feature/trade_page_element_id to develop December 8, 2023 09:17
@Julian0701 Julian0701 linked an issue Dec 8, 2023 that may be closed by this pull request
根據 Lighthouse 指標優化 TBD (2/2) #1479
Closed
@Julian0701 Julian0701 marked this pull request as ready for review December 12, 2023 01:31
Luphia
Luphia approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 4f0f655 into develop Dec 18, 2023
2 of 8 checks passed
@Luphia Luphia deleted the feature/lighthouse_enhancement branch December 18, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@arealclimber arealclimber Awaiting requested review from arealclimber

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

根據 Lighthouse 指標優化 TBD (2/2) 根據 Lighthouse 指標優化 TBD (1/2)
2 participants
@Julian0701 @Luphia