Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230602 julian #807

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Feature/20230602 julian #807

merged 15 commits into from
Jun 7, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Jun 2, 2023 •
edited
Loading

DEVELOP

  • DatePicker
  • OpenSubTab
  • ReceiptSection
  • ReceiptItem
  • MarketContext

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 2
    • src/components/receipt_section/receipt_section.tsx line20
    • src/components/receipt_section/receipt_section.tsx line51
  • high risk: 0
  • new sql: 0

UML

@Julian0701 Julian0701 requested a review from Luphia June 2, 2023 10:58
@Julian0701 Julian0701 self-assigned this Jun 2, 2023
@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 2:06am

This was linked to issues Jun 2, 2023
[BUG] Date Picker 的日期不見 #769
Closed
[BUG] 同一個倉位，在 Trade 和 My Assets 顯示的 PNL 不一致 #792
Closed
[BUG] PNL 計算錯誤 #768
Closed
@Julian0701 Julian0701 marked this pull request as draft June 2, 2023 11:44
@Julian0701 Julian0701 marked this pull request as ready for review June 5, 2023 07:02
@Julian0701 Julian0701 linked an issue Jun 5, 2023 that may be closed by this pull request
Trading Header 的價格顏色不夠明顯 #800
Closed
@Julian0701 Julian0701 marked this pull request as draft June 5, 2023 11:01
@Julian0701 Julian0701 marked this pull request as ready for review June 6, 2023 02:07
@Julian0701 Julian0701 linked an issue Jun 6, 2023 that may be closed by this pull request
My account & Language 選單不會自己關閉 #806
Closed
arealclimber
arealclimber approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@arealclimber arealclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

TzuHanLiang
TzuHanLiang approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@TzuHanLiang TzuHanLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

Luphia
Luphia approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 5054307 into develop Jun 7, 2023
@Luphia Luphia deleted the feature/20230602_julian branch March 8, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arealclimber arealclimber arealclimber approved these changes

@TzuHanLiang TzuHanLiang TzuHanLiang approved these changes

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Julian0701 @Luphia @TzuHanLiang @arealclimber