Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/20230608 julian #851

Merged
merged 5 commits into from
Jun 10, 2023

Conversation

Julian0701
Copy link
Member

DEVELOP

  • PersonalAchievementModal
  • LeaderboardTab

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • high risk: 0
  • new sql: 0

UML

@Julian0701 Julian0701 self-assigned this Jun 8, 2023
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 5:24am

@Julian0701 Julian0701 linked an issue Jun 8, 2023 that may be closed by this pull request
1 task
export const accountTruncate = (text: string) => {
return text?.substring(0, 6) + '...' + text?.substring(text.length - 5);
export const accountTruncate = (text: string, limitLength: number) => {
return text?.length >= limitLength
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return 不能有判斷式

Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 2e8c711 into feature/getPersonalAchievement Jun 10, 2023
@Luphia Luphia deleted the feature/20230608_julian branch June 10, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

頁面串接 getPersonalAchievemt
2 participants