Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230613 julian #875

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Feature/20230613 julian #875

merged 3 commits into from
Jun 13, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Jun 13, 2023 •
edited
Loading

DEVELOP

  • OpenPositionItem
  • PersonalAchievementModal

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • high risk: 0
  • new sql: 0

UML

@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 3:47am

@Julian0701 Julian0701 requested a review from Luphia June 13, 2023 03:21
@Julian0701 Julian0701 self-assigned this Jun 13, 2023
Luphia
Luphia approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 8c3987e into develop Jun 13, 2023
@Luphia Luphia deleted the feature/20230613_julian branch June 13, 2023 13:14
@Julian0701 Julian0701 linked an issue Jun 14, 2023 that may be closed by this pull request
調整 getPersonalAchievements 的時間點 #873
Closed
@Julian0701 Julian0701 linked an issue Mar 1, 2024 that may be closed by this pull request
調整 PNL 為零時的顏色 #872
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

調整 getPersonalAchievements 的時間點 調整 PNL 為零時的顏色
2 participants
@Julian0701 @Luphia