Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play: 🐸 show correct quotation after ticker changed #847 #876

Merged
merged 5 commits into from
Jun 13, 2023
Merged

play: 🐸 show correct quotation after ticker changed #847 #876

merged 5 commits into from
Jun 13, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jun 13, 2023 •
edited
Loading

DEVELOP

  • OpenPositionItem
  • OpenSubTab
  • PositionClosedModal

CHECK LIST

UML

@arealclimber arealclimber self-assigned this Jun 13, 2023
@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 1:22pm

@arealclimber arealclimber linked an issue Jun 13, 2023 that may be closed by this pull request
[BUG] 切換交易對後的關倉，要拿該交易對的報價單 #847
Closed
2 tasks
@arealclimber arealclimber linked an issue Jun 13, 2023 that may be closed by this pull request
[BUG] PNL in close modal changes at the fixed close price #877
Closed
@arealclimber arealclimber marked this pull request as ready for review June 13, 2023 06:41
TzuHanLiang
TzuHanLiang approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@TzuHanLiang TzuHanLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked

Luphia
Luphia approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 4934dbf into develop Jun 13, 2023
@Luphia Luphia deleted the fix/quote branch June 13, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TzuHanLiang TzuHanLiang TzuHanLiang approved these changes

@Luphia Luphia Luphia approved these changes

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arealclimber @Luphia @TzuHanLiang