Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ux modal tickerbox #907

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Feature/ux modal tickerbox #907

merged 6 commits into from
Jun 19, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jun 17, 2023 •
edited
Loading

DEVELOP

  • CryptoCategory
  • TickerSelectorBox
  • TickerSelectorBoxMobile
  • PositionOpenModal

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@vercel
Copy link

vercel bot commented Jun 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 2:00am

@arealclimber arealclimber self-assigned this Jun 17, 2023
This was linked to issues Jun 17, 2023
[BUG] Website crashes when clicking the ticker box #893
Closed
After opening position, showing the update modal #906
Closed
@arealclimber arealclimber marked this pull request as ready for review June 17, 2023 04:58
@arealclimber arealclimber added this to the v0.8.0 Alpha milestone Jun 17, 2023
Luphia
Luphia approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 6acdcf0 into develop Jun 19, 2023
@Luphia Luphia deleted the feature/ux-modal-tickerbox branch June 19, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

After opening position, showing the update modal [BUG] Website crashes when clicking the ticker box
2 participants
@arealclimber @Luphia