Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:fix assets update bug #908

Merged
merged 1 commit into from
Jun 17, 2023
Merged

feat:fix assets update bug #908

merged 1 commit into from
Jun 17, 2023

Conversation

TzuHanLiang
Copy link
Member

DEVELOP

Context

  • UserContext
  • WorkerContext

ISSUES

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new libraries: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk operation: 0
  • SQL operation: 0

UML

@vercel
Copy link

vercel bot commented Jun 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 6:05am

@TzuHanLiang TzuHanLiang self-assigned this Jun 17, 2023
@TzuHanLiang TzuHanLiang requested a review from Julian0701 June 17, 2023 06:04
@TzuHanLiang TzuHanLiang added this to the v0.8.0 Alpha milestone Jun 17, 2023
@TzuHanLiang TzuHanLiang linked an issue Jun 17, 2023 that may be closed by this pull request
[BUG] Balance on NavBar doesn't change immediately after closing the position #885
Closed
@TzuHanLiang TzuHanLiang mentioned this pull request Jun 17, 2023
Closed
arealclimber
arealclimber approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@arealclimber arealclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Luphia
Luphia approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit b4d7dad into develop Jun 17, 2023
@Luphia Luphia deleted the bug/assets_update branch June 17, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arealclimber arealclimber arealclimber approved these changes

@Luphia Luphia Luphia approved these changes

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@TzuHanLiang TzuHanLiang

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

[BUG] Balance on NavBar doesn't change immediately after closing the position
3 participants
@TzuHanLiang @Luphia @arealclimber