Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/restyle homepage #917

Merged
merged 18 commits into from
Jun 21, 2023
Merged

Feature/restyle homepage #917

merged 18 commits into from
Jun 21, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jun 19, 2023 •
edited
Loading

DEVELOP

  • ReserveRatio
  • NavBarMobile
  • NavBar
  • HeroDescription
  • Notification

更改 modal 的 z-index

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 2
    • src/components/audit_report/audit_report.tsx
    • src/components/reserve_card/reserve_card.tsx
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber arealclimber self-assigned this Jun 19, 2023
@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 2:46am

This was linked to issues Jun 19, 2023
Desktop - Home page refactor #914
Closed
Mobile - Home page refactor #915
Closed
@arealclimber arealclimber linked an issue Jun 20, 2023 that may be closed by this pull request
Notification optimization #923
Closed
@arealclimber arealclimber marked this pull request as ready for review June 20, 2023 06:01
@arealclimber arealclimber requested review from Julian0701, TzuHanLiang and Luphia and removed request for Julian0701 and TzuHanLiang June 20, 2023 06:01
@arealclimber arealclimber added this to the v0.8.0 Alpha milestone Jun 20, 2023
Luphia
Luphia approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit bdb4112 into develop Jun 21, 2023
@Luphia Luphia deleted the feature/restyle-homepage branch June 21, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@Julian0701 Julian0701 Awaiting requested review from Julian0701

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

Notification optimization Mobile - Home page refactor Desktop - Home page refactor
2 participants
@arealclimber @Luphia