Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 i18n json http request 404 error #924

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix: 🐛 i18n json http request 404 error #924

merged 3 commits into from
Jun 20, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jun 20, 2023 •
edited
Loading

DEVELOP

  • /pages/news/[newsId].tsx

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 1 (upgrade)
    • @cafeca/lunar: 0.5.8
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber arealclimber self-assigned this Jun 20, 2023
@vercel
Copy link

vercel bot commented Jun 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:33pm

@arealclimber arealclimber marked this pull request as ready for review June 20, 2023 06:15
@arealclimber arealclimber linked an issue Jun 20, 2023 that may be closed by this pull request
[BUG] News article i18n HTTP request 404 #884
Closed
@arealclimber arealclimber added this to the v0.8.0 Alpha milestone Jun 20, 2023
@arealclimber arealclimber linked an issue Jun 20, 2023 that may be closed by this pull request
[BUG] No exception is thrown when the user denies the signature #759
Closed
Luphia
Luphia approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 183425d into develop Jun 20, 2023
@Luphia Luphia deleted the fix/newsid-404-http-request branch June 20, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

[BUG] News article i18n HTTP request 404 [BUG] No exception is thrown when the user denies the signature
2 participants
@arealclimber @Luphia