Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/trade_tab_loading #972

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Feature/trade_tab_loading #972

merged 4 commits into from
Jul 11, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Jul 5, 2023 •
edited
Loading

DEVELOP

  • OpenSubTab
  • OpenSubTabMobile
  • HistorySubTab
  • HistorySubTabMobile

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • high risk: 0
  • new sql: 0

UML

@Julian0701 Julian0701 self-assigned this Jul 5, 2023
@vercel
Copy link

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 7:16am

@Julian0701 Julian0701 linked an issue Jul 5, 2023 that may be closed by this pull request
Trade Tab 載入優化 #932
Closed
arealclimber
arealclimber approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@arealclimber arealclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TzuHanLiang
TzuHanLiang reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@TzuHanLiang TzuHanLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • loooked

Luphia
Luphia approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 77da8cb into develop Jul 11, 2023
@Luphia Luphia deleted the feature/trade_tab_loading branch July 11, 2023 05:35
@Julian0701 Julian0701 mentioned this pull request Jul 17, 2023
Closed
@Julian0701 Julian0701 linked an issue Jan 12, 2024 that may be closed by this pull request
[BUG] 手機版 history position 沒有照時間排序 #984
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TzuHanLiang TzuHanLiang TzuHanLiang left review comments

@arealclimber arealclimber arealclimber approved these changes

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 手機版 history position 沒有照時間排序 Trade Tab 載入優化
4 participants
@Julian0701 @Luphia @TzuHanLiang @arealclimber