Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/trade book #976

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix/trade book #976

merged 1 commit into from
Jul 11, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jul 6, 2023 •
edited
Loading

DEVELOP

  • src/lib/books/trade_book.ts

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber arealclimber self-assigned this Jul 6, 2023
@vercel
Copy link

vercel bot commented Jul 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 4:44am

@arealclimber arealclimber linked an issue Jul 6, 2023 that may be closed by this pull request
TradeBook 放一陣子會 crash #974
Closed
@arealclimber arealclimber marked this pull request as ready for review July 6, 2023 09:35
TzuHanLiang
TzuHanLiang reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@TzuHanLiang TzuHanLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked

Luphia
Luphia approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

Julian0701
Julian0701 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Julian0701 Julian0701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked

@Luphia Luphia merged commit 38fb779 into refactor/trade-book Jul 11, 2023
@Luphia Luphia deleted the fix/trade-book branch July 11, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TzuHanLiang TzuHanLiang TzuHanLiang left review comments

@Julian0701 Julian0701 Julian0701 approved these changes

@Luphia Luphia Luphia approved these changes

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TradeBook 放一陣子會 crash
4 participants
@arealclimber @Luphia @TzuHanLiang @Julian0701