Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/candlestick #980

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Feature/candlestick #980

merged 7 commits into from
Jul 11, 2023

Conversation

TzuHanLiang
Copy link
Member

DEVELOP

Context

  • UserContext
  • ReceiptItem

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new libraries: 0
  • new Class / Component: 0
  • new loop: 2
    • UserContext
      • ln1333
      • ln1334 -ln1344
  • new recursive: 0
  • high risk operation: 0
  • SQL operation: 0

UML

@vercel
Copy link

vercel bot commented Jul 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 5:56am

@TzuHanLiang TzuHanLiang requested a review from Luphia July 7, 2023 09:23
@TzuHanLiang TzuHanLiang self-assigned this Jul 7, 2023
@TzuHanLiang TzuHanLiang added this to the v0.8.0 Alpha milestone Jul 7, 2023
This was linked to issues Jul 7, 2023
[BUG] My Assets 的 close position 點擊後沒反應 #965
Closed
在 MarketContext 新增 candlestick API #979
Closed
Julian0701
Julian0701 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Julian0701 Julian0701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@Julian0701 Julian0701 self-requested a review July 7, 2023 11:26
@TzuHanLiang TzuHanLiang requested a review from arealclimber July 10, 2023 02:08
arealclimber
arealclimber approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@arealclimber arealclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Luphia
Luphia approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 22969fe into develop Jul 11, 2023
@Luphia Luphia deleted the feature/candlestick branch July 11, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian0701 Julian0701 Julian0701 approved these changes

@arealclimber arealclimber arealclimber approved these changes

@Luphia Luphia Luphia approved these changes

Assignees

@TzuHanLiang TzuHanLiang

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging this pull request may close these issues.

在 MarketContext 新增 candlestick API [BUG] My Assets 的 close position 點擊後沒反應
5 participants
@TzuHanLiang @Luphia @arealclimber @Julian0701 @Luphia1984