Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent segfault in casacore log sink destructor #1398

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Prevent segfault in casacore log sink destructor #1398

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff8f64f
Use a different method to set local and global sink without reusing a…
confluence Jan 27, 2025
13907c0
Added changelog entry
confluence Jan 27, 2025
306182c
Remove unused local casacore log object
confluence Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Fix save image/export regions bug which could cause directory overwrite or deletion ([#1377](https://github.com/CARTAvis/carta-backend/issues/1377)).
* Fix bug in cache slicer transformation which affects some images with rotated axes ([#1389](https://github.com/CARTAvis/carta-backend/pull/1389)).
* Fix bug accessing top (root) folder of file browser ([#2354](https://github.com/CARTAvis/carta-frontend/issues/2354)).
* Fix segfault after early exit ([#1382](https://github.com/CARTAvis/carta-backend/issues/1382)).

### Changed
* Move the loader cache to separate files ([#1021](https://github.com/CARTAvis/carta-backend/issues/1021)).
Expand Down
3 changes: 1 addition & 2 deletions src/Main/Main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,8 @@ int main(int argc, char* argv[]) {
default:
carta_log_sink = new CartaLogSink(casacore::LogMessage::NORMAL);
}
casacore::LogSink log_sink(carta_log_sink->filter(), std::shared_ptr<casacore::LogSinkInterface>(carta_log_sink));
casacore::LogSink::globalSink(carta_log_sink);
casacore::LogIO casacore_log(log_sink);
casacore::LogIO casacore_log;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LogIO not needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; this object is actually never used.


if (settings.wait_time >= 0) {
Session::SetExitTimeout(settings.wait_time);
Expand Down
Loading