Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwrite field to SaveFile, ExportRegion #97

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

pford
Copy link
Contributor

@pford pford commented May 24, 2024

To prevent accidental overwrite of existing image, directory, or file, add overwrite flag to SaveFile and ExportRegion.

@pford
Copy link
Contributor Author

pford commented Jun 11, 2024

@YuHsuan-Hwang I incremented the major version to 29, since saving the image fails even after the user confirms the overwrite without this version in the frontend. If you think it is a minor version change, let me know.

@pford pford marked this pull request as ready for review June 11, 2024 16:51
@pford pford requested a review from YuHsuan-Hwang June 11, 2024 16:51
@pford pford added the backport for issues that require backporting to an existing release label Jun 11, 2024
@YuHsuan-Hwang
Copy link
Contributor

@YuHsuan-Hwang I incremented the major version to 29, since saving the image fails even after the user confirms the overwrite without this version in the frontend. If you think it is a minor version change, let me know.

Sounds good to me. 👍

@pford pford changed the title Add overwrite field to SaveFile Add overwrite field to SaveFile, ExportRegion Jun 26, 2024
@confluence confluence merged commit deaaf0a into dev Aug 19, 2024
@confluence confluence deleted the save_file_overwrite branch August 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport for issues that require backporting to an existing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants