Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a parameter for reordering genotype samples directly after reading them #228

Closed
wants to merge 9 commits into from

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Nov 17, 2023

No description provided.

@aryarm
Copy link
Member Author

aryarm commented Nov 17, 2023

marking this as a draft PR because I still need to handle situations where there are duplicate samples or nonexistent samples passed via the samples parameter. We didn't have to worry about this before because cyvcf2 would handle it for us, but it's probably a good idea to think about now that we are actually treating the samples parameter as a list instead of a set

also I should disable the warning by passing reorder_samples=False in all of the places where it doesn't matter

@aryarm
Copy link
Member Author

aryarm commented Dec 2, 2023

this PR was overriden by #230

@aryarm aryarm deleted the feat/reorder-samples branch December 2, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant