feat: allow multiple variants in pearson_corr_ld()
#258
+86
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryarm
changed the title
pearson_corr_ldpearson_corr_ld()
|
@mlamkin7 , is there any chance you can review this PR? I seem to recall us talking about wanting to implement this change a while ago, and I don't remember why I didn't do it at that point. In any case, here it is |
mlamkin7
approved these changes
Nov 7, 2024
|
Thanks for the review!! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to compute LD between any number of variants at once, which is faster than computing it sequentially.
I had to do some shenanigans to get the output to be the shape that I would expect it to be.