Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Implicit declaration of these functions throws warning during build #948

Merged
merged 2 commits into from
Feb 28, 2018
Merged

[FIX] Implicit declaration of these functions throws warning during build #948

merged 2 commits into from
Feb 28, 2018

Conversation

krushanbauva
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • [x ] I have read and understood the contributors guide.
  • [ x] I have checked that another pull request for this purpose does not exist.
  • [x ] I have considered, and confirmed that this submission will be valuable to others.
  • [x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x ] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • [ x] I have used CCExtractor just a couple of times.
  • [ x] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Should I declare these functions in a header file and include the header file rather than doing it this way?

P.S.: I used the build script on my linux machine which throws warning

@@ -39,6 +39,10 @@ GF_Err CanAccessMovie(GF_ISOFile *movie, u32 Mode)
return GF_OK;
}

s32 gf_lang_find(const char *);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s32 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the way this function is defined in src/gpacmp4/error.c

Also, you can find "typedef int s32" in src/gpacmp4/gpac/setup.h

@cfsmp3
Copy link
Contributor

cfsmp3 commented Feb 28, 2018

I'm merging because I'm tired of seeing those warnings myself, even though I'm not a fan of changing libgpac directly.
It would be a good idea to also send this minor thing to the libgpac maintainers.

@cfsmp3 cfsmp3 merged commit 3267c68 into CCExtractor:master Feb 28, 2018
@krushanbauva
Copy link
Contributor Author

krushanbauva commented Feb 28, 2018

Also, I was planning to go through all those warnings one by one and fix them! :)
@cfsmp3 Should I really spend time on it?

@krushanbauva
Copy link
Contributor Author

@cfsmp3 This issue doesn't arise in gpac library. The function is already declared in a header file gpac/include/gpac/iso639.h which is included in the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants