Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming sample_infections to compute_future_infections #137

Merged
merged 3 commits into from
May 28, 2024
Merged

Renaming sample_infections to compute_future_infections #137

merged 3 commits into from
May 28, 2024

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented May 28, 2024 •
edited
Loading

Renames functions to avoid suggesting stochasticity.

@gvegayon gvegayon linked an issue May 28, 2024 that may be closed by this pull request
Rename sample_infections to compute_infections #132
Closed
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (4dd40bb) to head (72fec94).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          34       34           
  Lines         683      683           
=======================================
  Hits          630      630           
  Misses         53       53
Flag Coverage Δ
unittests 92.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dylanhmorris
dylanhmorris reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the main issue suggested compute_future_infections but on review I might suggest

compute_infections_from_rt
and
compute_infections_from_rt_with_feedback

Thoughts @gvegayon @damonbayer ?

@gvegayon
Copy link
Member Author

I know the main issue suggested compute_future_infections but on review I might suggest

compute_infections_from_rt and compute_infections_from_rt_with_feedback

Thoughts @gvegayon @damonbayer ?

I like that better. Updating

dylanhmorris
dylanhmorris reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an update to the function name

model/src/pyrenew/latent/infections.py Outdated Show resolved Hide resolved
dylanhmorris
dylanhmorris approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvegayon gvegayon merged commit 32955cc into main May 28, 2024
8 checks passed
@gvegayon gvegayon deleted the 132-rename-sample_infections-to-compute_infections branch May 28, 2024 21:06
@gvegayon gvegayon mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhmorris dylanhmorris dylanhmorris approved these changes

@damonbayer damonbayer Awaiting requested review from damonbayer damonbayer is a code owner

@AFg6K7h4fhy2 AFg6K7h4fhy2 Awaiting requested review from AFg6K7h4fhy2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename sample_infections to compute_infections
2 participants
@gvegayon @dylanhmorris