-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming variables throughout for clarity #179
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 94.77% 94.75% -0.02%
==========================================
Files 39 39
Lines 842 839 -3
==========================================
- Hits 798 795 -3
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good for the most part (see comments for flags and or suggestions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another small remark regarding outdated use of typing
.
Co-authored-by: upx3—TM (CFA) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. See comment history.
Closes #156.
No changes to any of the model workings. Just renaming variables to make things easier to follow.
For example:
x_dist
that are actually random variables are renamedx_rv
latent
are renamed to be more specific likelatent_infections
orlatent_hosp_admissions
predicted
as a descriptor is replaced byobserved
orsampled
where appropriateihr
are replaced by more descriptive terms likeinfection_hosp_rate
i0
is consistently formatted asI0