Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials formatting #220

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Update tutorials formatting #220

merged 1 commit into from
Jun 27, 2024

Conversation

damonbayer
Copy link
Collaborator

See #159.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (5748007) to head (3d7cc5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          40       40           
  Lines         877      877           
=======================================
  Hits          811      811           
  Misses         66       66           
Flag Coverage Δ
unittests 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris
Copy link
Collaborator

dylanhmorris commented Jun 27, 2024

Confirming this does not (and is not intended to) close #159, correct? It does the formatting, but doesn't set it up in pre-commit, yes?

@damonbayer
Copy link
Collaborator Author

@dylanhmorris That's correct. I only linked to #159 to explain why it was not done automatically.

@sbidari
Copy link
Collaborator

sbidari commented Jun 27, 2024

I am confused. Is this formatting done automatically, or no? @damonbayer @dylanhmorris

@damonbayer
Copy link
Collaborator Author

damonbayer commented Jun 27, 2024

It can be done semi-automatically in VS Code. However, it only works on a cell-by-cell basis, so you have to go through each cell and issue a formatting command (or re-save the file if you have format on save enabled). This is what I did to create the changes in this PR.

As far as I know, there is no way to format an entire qmd at once, but that would be really nice to have in pre-commit.

@damonbayer
Copy link
Collaborator Author

Anyone willing to approve this @dylanhmorris @sbidari @AFg6K7h4fhy2 ?

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylanhmorris dylanhmorris merged commit ae4424f into main Jun 27, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the dmb_formatting_tutorials branch June 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants