Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image rendering in basic renewal model tutorial #272

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jul 16, 2024

adds plt.show() to ensure that images render properly in the webpage

@sbidari sbidari linked an issue Jul 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (a622187) to head (5f95536).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          40       40           
  Lines         909      909           
=======================================
  Hits          843      843           
  Misses         66       66           
Flag Coverage Δ
unittests 92.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the CI rendered version and it looks right to me. Code also looks right. Thanks for the fix, @sbidari!

@dylanhmorris dylanhmorris merged commit 0219353 into main Jul 16, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the 271-fix-image-rendering-in-the-website branch July 16, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix image rendering in the website
2 participants