Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weekday From Hospital Admissions Tutorial #295

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

Removes weekday from hospital admissions tutorial variable names given that there is no longer a weekday effect present following #281

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Jul 23, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the O sprint milestone Jul 23, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Jul 23, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (accaaaf) to head (b319805).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         903      903           
=======================================
  Hits          838      838           
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AFg6K7h4fhy2

@dylanhmorris dylanhmorris merged commit cb2b0c6 into main Jul 23, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the 294-UPX3-remove-references-to-weekday-in-hospital-admissions-model-tutorial branch July 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to weekday in hospital admissions model tutorial
2 participants