Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Naming Of n_timepoints_to_simulate #305

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

As per #249 , n_timepoints_to_simulate can be shortened; this PR shortens n_timepoints_to_simulate to n_datapoints.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Jul 24, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the 🦆 Olorotitan milestone Jul 24, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (e3c0923) to head (f8a9256).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         903      903           
=======================================
  Hits          838      838           
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @AFg6K7h4fhy2!

@gvegayon gvegayon merged commit e429581 into main Jul 24, 2024
8 checks passed
@gvegayon gvegayon deleted the 249-UPX3-n-timepoints-renaming branch July 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light refactor of models based on experience with Predictive, forecasting, and plans for time handling.
2 participants