Dynamic and static distributional rvs #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates
DistributionalRV
intoStaticDistributionalRV
, in which the distribution is already instantiated (has fixed parameter values) andDynamicDistributionalRV
, in which the distribution is instantiated whensample()
is called with keyword arguments taken from thesample()
call. The latter is designed to serve as a wrapper class for working with distributions with inferred parameters.It also
dist
keyword arg toDistributionalRV
todistribution
, to avoid clashes given the standardnumpyro
pattern ofimport numpyro.distributions as dist
.