-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra mathematical description of discrete delay distributions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Sam. Very clear!
ghost
deleted the
43-mathematical-description
branch
March 26, 2024 16:41
ghost
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Update description of discrete delay distributions * remove double desciption * minor eq fix * Update equations.md * update equations.md contents * Update equations.md * fix contents
gvegayon
added a commit
that referenced
this pull request
Apr 3, 2024
…39) * Copy doc from wastewater model on Hosp Admin to class * Rename metaclasses to metaclass (#36) * Create typos.yaml (#42) * Create typos.yaml * Does this make it run on the whole repo? * remove trailing whitespace * Delete .github/workflows/typos.yaml trying to use typos in pre-commit instead * Update .pre-commit-config.yaml add typos to pre-commit * fixed typos * 34 port notebooks under modeldocs to quarto (#35) * Porting to quarto and adding a makefile entry to render them * Now it should be easier to deal with pre-commit under docs (only skipping cache) * Forgot to remove the pyrenew_demo notebook * Update model/Makefile * Fixing typos * Removes progress bar - adds doc/ figures - sets jupyter as kernel * Update model/docs/getting-started.qmd Co-authored-by: Dylan H. Morris <[email protected]> --------- Co-authored-by: Dylan H. Morris <[email protected]> * Extra mathematical description of discrete delay distributions (#44) * Update description of discrete delay distributions * remove double desciption * minor eq fix * Update equations.md * update equations.md contents * Update equations.md * fix contents * Escaping tau * Adding deterministic obs and process to the equation * Cleaning the quarto documents and working on the getting started diagram * Flexible IHR (now RandomVariable) * Adding weekday and phosp effect to latent hosp * Adding back figures * Adding a test for deterministic/stochastic weekday effect * Typo Co-authored-by: Dylan H. Morris <[email protected]> * Correcting tests (class name) and improving readme a bit * Adding deterministic module (midway, expected to fail) [skip ci] * Refactoring I0 and gen_int (expected to fail) [skip ci] * gen_int and I0 now are directly passed to the models * In latent hosp, change inf_hosp_int to inform_hosp (clearer name) * Adding missing figures (pyrenew demo was not compiling) * Renaming inform_hosp * Removing defaults for hosp rate * Changing language (initial infections) + adding section to getting-started * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <[email protected]> * Addressing comments on default priors and varnames * Rt is not default now for basic model * Commas and title * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <[email protected]> * Renaming hosp reporting variable in latent var * Renaming hosp report * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <[email protected]> * Final renaming of vars in tests * Different vector for hosp_report_prob_dist in tests --------- Co-authored-by: George G. Vega Yon <[email protected]> Co-authored-by: George G Vega Yon <[email protected]> Co-authored-by: Nate McIntosh <[email protected]> Co-authored-by: Dylan H. Morris <[email protected]> Co-authored-by: Samuel Brand <[email protected]> Co-authored-by: George G. Vega Yon <[email protected]> Co-authored-by: Dylan H. Morris <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to equations.md to increase amount of detail on interval censoring and truncation for delay distributions.
Closes #43