Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tutorial build #469

Conversation

dylanhmorris
Copy link
Collaborator

Closes #468

…now-that-they-are-built-as-part-of-the-standard-sphinx-build-html-workflow
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (27258c1) to head (8f7bbe6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          42       42           
  Lines        1003     1003           
=======================================
  Hits          948      948           
  Misses         55       55           
Flag Coverage Δ
unittests 94.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris dylanhmorris marked this pull request as draft October 2, 2024 18:09
@dylanhmorris dylanhmorris marked this pull request as ready for review October 2, 2024 18:14
@dylanhmorris
Copy link
Collaborator Author

@damonbayer this is ready for review. If and when you approve, we can remove render-docs as a required check.

@damonbayer damonbayer merged commit 20df5b3 into main Oct 2, 2024
7 checks passed
@damonbayer damonbayer deleted the 468-remove-redundant-pre-build-of-tutorials-now-that-they-are-built-as-part-of-the-standard-sphinx-build-html-workflow branch October 2, 2024 18:27
@damonbayer
Copy link
Collaborator

@damonbayer this is ready for review. If and when you approve, we can remove render-docs as a required check.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants