Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

50 standardize language #90

Merged
merged 11 commits into from
May 2, 2024
Merged

50 standardize language #90

merged 11 commits into from
May 2, 2024

Conversation

gvegayon
Copy link
Member

  • Changes hospitalizations to hospital admissions.
  • Changes IHR to infection_hosp_rate.

@gvegayon gvegayon linked an issue Apr 22, 2024 that may be closed by this pull request
Standardize language #50
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.48%. Comparing base (8d3689b) to head (6f69443).

Files Patch % Lines
model/src/pyrenew/latent/hospitaladmissions.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          33       33           
  Lines         634      634           
=======================================
  Hits          580      580           
  Misses         54       54
Flag Coverage Δ
unittests 91.48% <95.83%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvegayon gvegayon marked this pull request as ready for review April 26, 2024 19:14
@gvegayon
Copy link
Member Author

Flagging this for @dylanhmorris, @AFg6K7h4fhy2, and @cshelley!

dylanhmorris
dylanhmorris requested changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks largely good.

Main question is whether we really should be tracking docs/build in git.

Also some typo fixes.

docs/build/html/searchindex.js Outdated Show resolved Hide resolved
docs/build/html/_sources/msei_reference/model.rst.txt Outdated Show resolved Hide resolved
model/docs/example-with-datasets.md Outdated Show resolved Hide resolved
model/src/pyrenew/latent/hospitaladmissions.py Outdated Show resolved Hide resolved
model/src/pyrenew/latent/hospitaladmissions.py Outdated Show resolved Hide resolved
model/src/pyrenew/latent/hospitaladmissions.py Outdated Show resolved Hide resolved
model/src/pyrenew/model/rtinfectionsrenewalmodel.py Outdated Show resolved Hide resolved
model/src/pyrenew/model/rtinfectionsrenewalmodel.py Outdated Show resolved Hide resolved
model/src/test/test_latent_admissions.py Outdated Show resolved Hide resolved
model/src/test/test_latent_admissions.py Outdated Show resolved Hide resolved
@gvegayon gvegayon requested a review from dylanhmorris May 2, 2024 15:43
@dylanhmorris dylanhmorris merged commit a7c1349 into main May 2, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the 50-standardize-language branch May 2, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhmorris dylanhmorris dylanhmorris approved these changes

@AFg6K7h4fhy2 AFg6K7h4fhy2 Awaiting requested review from AFg6K7h4fhy2

@cshelley cshelley Awaiting requested review from cshelley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize language
2 participants
@gvegayon @dylanhmorris