Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment variables for ecr-viewer database #16

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Aug 20, 2024

Summary

  • Add two new environment variables for ecr viewer's DATABASE_TYPE and DATABASE_SCHEMA
  • Part of #2347

@BobanL BobanL requested a review from alismx August 20, 2024 10:15
Copy link
Collaborator

@alismx alismx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on descriptions, other than that, looks good.


variable "ecr_viewer_database_type" {
type = string
description = "Type of the ECR repositories"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you update this description and set a description on the other variable? Please be descriptive, this code may be used by our partners.

Copy link
Collaborator

@alismx alismx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@BobanL BobanL merged commit d0be5b9 into main Aug 21, 2024
1 check passed
@alismx alismx deleted the boban/2347-add-ecr-viewer-database-env-vars branch November 5, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants