Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update phdi_version + issue tempates 📜 #48

Merged
merged 5 commits into from
Dec 12, 2024
Merged

update phdi_version + issue tempates 📜 #48

merged 5 commits into from
Dec 12, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Nov 26, 2024 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • add templates
  • update version
  • minor OIDC permissions update

Additional information

@alismx alismx changed the title update PHDI_VERSION variable to latest update phdi_version variable + issue tempates 📜 Nov 26, 2024
@alismx alismx marked this pull request as ready for review November 26, 2024 23:42
@alismx alismx self-assigned this Nov 26, 2024
@alismx alismx changed the title update phdi_version variable + issue tempates 📜 update phdi_version + issue tempates 📜 Nov 27, 2024
@alismx alismx force-pushed the alis/upgrade/32 branch 2 times, most recently from f447c39 to f94cd1c Compare December 11, 2024 23:15
@alismx alismx force-pushed the alis/upgrade/32 branch 2 times, most recently from 3300586 to 36a7828 Compare December 12, 2024 00:05
Dev0717
Dev0717 approved these changes Dec 12, 2024 •
edited
Loading
View reviewed changes
shanice-skylight
shanice-skylight approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on IAM permissions

@alismx alismx merged commit e03512c into main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanice-skylight shanice-skylight shanice-skylight approved these changes

@Dev0717 Dev0717 Dev0717 approved these changes

@rin-skylight rin-skylight Awaiting requested review from rin-skylight

Assignees

@alismx alismx

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alismx @Dev0717 @shanice-skylight