-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gce report fix #27
Gce report fix #27
Conversation
scripts/plot_outputs.R
Outdated
"output", | ||
"person_demographics_count.csv" | ||
)) | ||
|
||
infectious_report <- readr::read_csv(file.path( | ||
"output", | ||
"person_infectious_count.csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The report here is called the person_infectious_count
whereas in main
it's called person_property_count
. Please update the report name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very curious of how hat even happened. We plotted something and "person_infectious_count.csv" does not exist on my computer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to person_property_count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from Chirag's catch on the person_property_count
variable name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Merging both reports into one. I'm also removing unused parameters related to the reports.