Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gce report fix #27

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Gce report fix #27

merged 3 commits into from
Dec 9, 2024

Conversation

confunguido
Copy link
Collaborator

Merging both reports into one. I'm also removing unused parameters related to the reports.

"output",
"person_demographics_count.csv"
))

infectious_report <- readr::read_csv(file.path(
"output",
"person_infectious_count.csv"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The report here is called the person_infectious_count whereas in main it's called person_property_count. Please update the report name here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very curious of how hat even happened. We plotted something and "person_infectious_count.csv" does not exist on my computer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to person_property_count

Copy link
Collaborator

@KOVALW KOVALW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from Chirag's catch on the person_property_count variable name

Copy link
Collaborator

@ChiragKumar9 ChiragKumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@confunguido confunguido merged commit 91c8fcf into main Dec 9, 2024
3 checks passed
@confunguido confunguido deleted the gce_report_fix branch December 9, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants