Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load testing script for process-zip 🤐 #3032

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Load testing script for process-zip 🤐 #3032

merged 3 commits into from
Dec 19, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Dec 10, 2024

PULL REQUEST

Summary

Adds a load-testing script

Related Issue

Resolves #3031

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

This works for our AWS install but should be treated mainly as a POC; it can be expanded in the future.
If anybody wants to test this, please reach out, and I will help with the setup.

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Testing Instructions

  • cd containers/ecr-viewer/seed-scripts
  • export LOAD_TESTING_URL=https://streamline.dibbs.cloud/
  • docker compose -f docker-compose-load.yml up --build
  • Visit http://0.0.0.0:8089/ in brower
  • Click START

@alismx alismx self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (bc02e2b) to head (528490c).
Report is 1543 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3032      +/-   ##
==========================================
- Coverage   89.69%   85.67%   -4.02%     
==========================================
  Files          15       25      +10     
  Lines         873     1424     +551     
==========================================
+ Hits          783     1220     +437     
- Misses         90      204     +114     
Flag Coverage Δ
orchestration 85.67% <ø> (?)
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 40 files with indirect coverage changes

with open(file, "rb") as opened_file:
data = {
"content_type": "application/zip",
"config_file_name": "sample-orchestration-s3-config.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this config name to be possibly non-integrated-extended to match more closely what people will actually be using?

"data_type": "zip",
"message_type": "ecr",
}
# print(f"Uploading {file}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# print(f"Uploading {file}")

@austin-hall-skylight
Copy link
Collaborator

I was initially reviewing this but have been unable to get the load test to run without all requests resulting in errors, despite Alis and I running it the same way. Can someone else try running it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locust spins up. I think it might be related to https://streamline.dibbs.cloud/ not being available.
image

@alismx alismx added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 0f6cfda Dec 19, 2024
16 checks passed
@alismx alismx deleted the alis/3031 branch December 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load testing setup
3 participants