Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add set id to core schema #3082

Merged
merged 4 commits into from
Dec 23, 2024
Merged

feat: add set id to core schema #3082

merged 4 commits into from
Dec 23, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 20, 2024

PULL REQUEST

Summary

  • Add set id to core schema

Related Issue

Fixes #3054

Acceptance Criteria

  • When seeding the database using the core schema, the set ID field is populated

Additional Information

image

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (0f6cfda) to head (edba2e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
+ Coverage   86.54%   91.24%   +4.69%     
==========================================
  Files         215      104     -111     
  Lines       13432     6339    -7093     
  Branches      666      667       +1     
==========================================
- Hits        11625     5784    -5841     
+ Misses       1798      534    -1264     
- Partials        9       21      +12     
Flag Coverage Δ
ecr-viewer 89.52% <ø> (+0.69%) ⬆️
fhir-converter ?
ingestion ?
message-parser 96.53% <ø> (ø)
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/app/api/save-fhir-data/save-fhir-data-service.ts 46.47% <ø> (+12.67%) ⬆️

... and 115 files with indirect coverage changes

Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BobanL BobanL added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 0fa0ec6 Dec 23, 2024
20 checks passed
@BobanL BobanL deleted the boban/3054-set-id-in-core branch December 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add set ID to core schema
2 participants