Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: date validation code #3139

Open
wants to merge 5 commits into
base: angela/2753-filter-by-date-p2
Choose a base branch
from

Conversation

mcmcgrath13
Copy link
Collaborator

PULL REQUEST

Summary

Refactor date validation code to be more reusable

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (db059c3) to head (bea3bc8).

Additional details and impacted files
@@                             Coverage Diff                              @@
##           mcm/angela/2753-filter-by-date-p2-params    #3139      +/-   ##
============================================================================
- Coverage                                     89.08%   85.67%   -3.42%     
============================================================================
  Files                                            82       25      -57     
  Lines                                          4297     1424    -2873     
  Branches                                        745        0     -745     
============================================================================
- Hits                                           3828     1220    -2608     
+ Misses                                          449      204     -245     
+ Partials                                         20        0      -20     
Flag Coverage Δ
ecr-viewer ?
orchestration 85.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 57 files with indirect coverage changes

Base automatically changed from mcm/angela/2753-filter-by-date-p2-params to angela/2753-filter-by-date-p2 January 16, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant