Add useEffect to prevent unnecessary submission fetches

[sean-usds]

The react component was getting stuck in a loop since every time submissions was set it would fire the fetch again. useEffect here will only trigger the fetch if organization or authState update.

Test Steps:

1. Go to submissions page
2. Open network console
3. Verify api call to submissions only happens once

This also removed an unnecessary JSON.parse

Checklist

Testing

• Tested locally?
• Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
• (For Changes to /frontend-react/...) Ran npm run lint:write?
• Added tests?

Process

• Are there licensing issues with any new dependencies introduced?
• Includes a summary of what a code reviewer should test/verify?
• Updated the release notes?
• Database changes are submitted as a separate PR?
• DevOps team has been notified if PR requires ops support?

Fixes

• #issue - List GitHub issues this PR fixes

To Be Done

Create GitHub issues to track the work remaining, if any

• #issue

Specific Security-related subjects a reviewer should pay specific attention to

• Does this PR introduce new endpoints?
  • new endpoint A
  • new endpoint B
• Does this PR include changes in authentication and/or authorization of existing endpoints?
• Does this change introduce new dependencies that need vetting?
• Does this change require changes to our infrastructure?
• Does logging contain sensitive data?
• Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

• What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
  • Spoofing (faking authenticity)
    • Threat T, which could be achieved by A, is mitigated by M
  • Tampering (influence or sabotage the integrity of information, data, or system)
  • Repudiation (the ability to dispute the origin or originator of an action)
  • Information disclosure (data made available to entities who should not have it)
  • Denial of service (make a resource unavailable)
  • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
• Have you ensured logging does not contain sensitive data?
• Have you received any additional approvals needed for this change?

Pull reviewers stats

Stats for the last 30 days:

	User	Total reviews	Median time to review	Total comments
	cwinters-usds	30	1h 46m	26
	MauriceReeves-usds	28	6h 58m	11
	jimduff-usds	21	1d 8h 36m	15
	kevinhaube	19	6h 33m	11
	sean-usds	18	2h 20m	8
	carlosfelix2	17	4h 34m	40
	RickHawesUSDS	16	4h 9m	6
	whytheplatypus	10	17h 22m	20
	TomNUSDS	9	2h 26m	12
	clediggins-usds	9	2h 26m	17
	jorg3lopez	5	6h 49m	0
	jbiskie	5	1h 26m	1
	brick-green-agile6	4	1h 5m	3
	JosiahSiegel	1	4m	2
	ahay-agile6	1	2d 16h 45m	0
	oslynn	1	2h 42m	0
	MikeC-A6	1	7h 7m	3
	rhood23699	1	14h 10m	0

Pull reviewers stats

Stats for the last 30 days:

	User	Total reviews	Median time to review	Total comments
	cwinters-usds	30	1h 46m	26
	MauriceReeves-usds	28	6h 58m	11
	jimduff-usds	21	1d 8h 36m	15
	sean-usds	21	1h 11m	8
	kevinhaube	20	1h 34m	11
	carlosfelix2	17	4h 34m	40
	RickHawesUSDS	16	4h 9m	6
	whytheplatypus	10	17h 22m	20
	TomNUSDS	9	2h 26m	12
	clediggins-usds	9	2h 26m	17
	jorg3lopez	5	6h 49m	0
	jbiskie	5	1h 26m	1
	brick-green-agile6	4	1h 5m	3
	JosiahSiegel	1	4m	2
	ahay-agile6	1	2d 16h 45m	0
	oslynn	1	2h 42m	0
	MikeC-A6	1	7h 7m	3
	rhood23699	1	14h 10m	0

[hannasage]

🔁

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication