Hotfix to catch MisconfiguredUserException (#8368)

CDCgov · Dec 19, 2024 · ead9fae · ead9fae
1 parent f939996
commit ead9fae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/backend/src/main/java/gov/cdc/usds/simplereport/service/ApiUserService.java b/backend/src/main/java/gov/cdc/usds/simplereport/service/ApiUserService.java
@@ -730,10 +730,14 @@ private UserInfo consolidateUser(ApiUser apiUser, PartialOktaUser oktaUser) {
     OrganizationRoles orgRoles =
         getOrganizationRoles(Optional.ofNullable(oktaClaims), apiUser, isSiteAdmin);
 
-    _dbOrgRoleClaimsService.checkOrgRoleClaimsEquality(
-        List.of(oktaClaims),
-        List.of(_dbOrgRoleClaimsService.getOrganizationRoleClaims(apiUser)),
-        apiUser.getLoginEmail());
+    try {
+      _dbOrgRoleClaimsService.checkOrgRoleClaimsEquality(
+          List.of(oktaClaims),
+          List.of(_dbOrgRoleClaimsService.getOrganizationRoleClaims(apiUser)),
+          apiUser.getLoginEmail());
+    } catch (MisconfiguredUserException e) {
+      log.error("Misconfigured organizations in DB for User ID: {}", apiUser.getInternalId());
+    }
     return new UserInfo(apiUser, Optional.of(orgRoles), isSiteAdmin, userStatus);
   }
 

diff --git a/backend/src/main/java/gov/cdc/usds/simplereport/service/DbOrgRoleClaimsService.java b/backend/src/main/java/gov/cdc/usds/simplereport/service/DbOrgRoleClaimsService.java
@@ -47,7 +47,10 @@ public List<OrganizationRoleClaims> getOrganizationRoleClaims(String username) {
   public OrganizationRoleClaims getOrganizationRoleClaims(ApiUser user) {
     Set<Organization> orgs = user.getOrganizations();
     if (orgs.size() != 1) {
-      log.error("Misconfigured organizations in DB for User ID: {}", user.getInternalId());
+      log.error(
+          "Misconfigured organizations in DB for User ID: {}. Number of organizations for user was: {}",
+          user.getInternalId(),
+          orgs.size());
       throw new MisconfiguredUserException();
     }
     Set<OrganizationRole> roles = user.getRoles();