Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to "Manage users" page for user list #8103

Open
emyl3 opened this issue Sep 5, 2024 · 2 comments · May be fixed by #8371
Open

Add pagination to "Manage users" page for user list #8103

emyl3 opened this issue Sep 5, 2024 · 2 comments · May be fixed by #8371
Assignees
@mpbrown
Milestone
[Epic] Okta Migra...

Comments

@emyl3
Copy link
Collaborator

emyl3 commented Sep 5, 2024 •
edited by DanielSass
Loading

Description

Add pagination to the "Manage users" page's user list. This will improve the user experience of not only larger orgs but is required for us to refactor the getAllUsersWithStatusForOrganization as part of the Okta migration work.

Image

Proposed solution

Add pagination to the "Manage users" page's user list

Additional context

  • This was a stopgap fix when we first handled this page for large orgs
  • Figma designs from when this was previously discussed
  • Our rate limit for READs on /api/v1/users/{id:.+} endpoint is 1000 per minute

Open questions

  • How should search behave?
    Search should search the entire org. Concerns about typeahead search being a pain with respect to the okta integration. Especially in the in-between state of this ticket and Update getUsersAndStatusInCurrentOrg to fetch users from DB #8108
  • How many users should we load at once?
    Lean on the figma, pair with Kenny to validate that it looks good.
@emyl3 emyl3 changed the title [WIP] Add pagination to "Manage users" page's user side nav [WIP] Add pagination to "Manage users" page for user list Sep 9, 2024
@emyl3 emyl3 changed the title [WIP] Add pagination to "Manage users" page for user list Add pagination to "Manage users" page for user list Sep 9, 2024
@emyl3 emyl3 added this to the [Epic] Okta Migration milestone Sep 9, 2024
This was referenced Sep 9, 2024
Open
Merged
@kenieh
Copy link
Collaborator

kenieh commented Sep 17, 2024

@jayna-SkylightDigital , @mpbrown and I think that our use case for this page has outgrown the USWDS component we're modeling this page after. In the future, we think this page could use a redesign.

The pagination being added to meet the Okta migration technical requirements doesn't provide any value for users and is also awkwardly placed. Unfortunately there isn't better placement for the pagination given how small the user sidebar is. Some things to consider for the future!

@jayna-SkylightDigital
Copy link
Collaborator

  1. No redesign will be completed at this time
  2. Text and icon information about the account (pending, deactivated) must be kept below the name
  3. Pagination will be added at the bottom (limits the number of users we need to get Okta information for on the initial page load)
  4. Limit to display only 10 users per screen.

@mpbrown mpbrown self-assigned this Dec 5, 2024
This was referenced Dec 24, 2024
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpbrown mpbrown

Labels
None yet
Projects
None yet
Milestone
[Epic] Okta Migration
Development

Successfully merging a pull request may close this issue.

Add frontend support for Manage Users pagination CDCgov/prime-simplereport
5 participants
@DanielSass @emyl3 @mpbrown @kenieh @jayna-SkylightDigital