Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Testing
I did some manual testing with very large files just to verify how things behave. I did this with repeated records (5 records copied and pasted until we had x# in the file) so it's not particularly prod-like. Might look at writing a quick python script to generate data with faker or something like that in the future.
For context: 9999 records is the most the front end will let you submit. I believe looking at metabase the largest file uploads we've seen in prod are ~4000 records. The overwhelming majority are under ~2000 records.
Of note - these timings don't include the report stream interaction, and for larger files I've noticed this is significant - at least for local dev.
Execution time pre-async
Execution time post-async