Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nested try catch #6760

Merged
merged 2 commits into from
Oct 23, 2023
Merged

remove nested try catch #6760

merged 2 commits into from
Oct 23, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Oct 17, 2023 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Pull out hasPassed logic into it's own method .

Additional Information

Testing

@BobanL BobanL marked this pull request as ready for review October 20, 2023 13:01
fzhao99
fzhao99 previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@BobanL BobanL requested review from zdeveloper and fzhao99 October 20, 2023 17:52
@BobanL BobanL enabled auto-merge October 20, 2023 18:06
emyl3
emyl3 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you!

zdeveloper
zdeveloper approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@BobanL BobanL added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 5140abc Oct 23, 2023
32 checks passed
@BobanL BobanL deleted the boban/5597-remove-nested-try-catch branch October 23, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@zdeveloper zdeveloper zdeveloper approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@johanna-skylight johanna-skylight Awaiting requested review from johanna-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nested try catch blocks
4 participants
@BobanL @zdeveloper @emyl3 @fzhao99