-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use /actuator/health for backend health checks #6777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you for uncovering and fixing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
three cheers for boban
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does /api/actuator/health
endpoint work for metabase? I thought the standard metabase healthcheck endpoint was /api/health
.
Kudos, SonarCloud Quality Gate passed! |
No,
Good callout, I have reverted the health check for metabase! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for these updates.
DEVOPS PULL REQUEST
Related Issue
/
endpoint. The/
endpoint was failing our security rules because we did not also permit access to/index.html
. It seems better that we just remove access to/
and then use/actuator/health
for health check accross the app.Changes Proposed
/actuator/health
endpoint/health
was being check with/actuator/health
/
endpoint in security configindex.html
Additional Information
/health
endpoint only ever returns 200 OK which is not that useful. SpringBoot already gives us more information in actuator so I thought it would be best to just remove it to reduce confusion.Dev5 now:
Dev6:
Testing
/health
and/
and 200 OK on/actuator/health