feat: Ignore tags

[alismx]

DEVOPS PULL REQUEST

Related Issue

• resolves Update terraform to ignore tags #6822

Changes Proposed

• This Pull Request changes the resource_group tag to be based on data.azurerm_resource_group.dev.name instead of "${local.project}-${local.name}-${local.env_level}" or "${local.project}-${local.name}-${local.env}". This brings consistency across all environment configs as some were using local.env which would tag dev(2,3,4,5...) incorrectly. By making this update, we can reduce some future mental overhead when reading through the code to understand which resource group a resource belongs to. I'll call out an example inline on a dev3 file where this caused an inconsistency.
• This PR also introduces lifecycle blocks to several resources to eliminate needless tag updates. The CDC is pretty much in charge of our tags and we don't use them for any meaningful purpose, we don't need to track or update the values of them.

Testing

• Reviewers should verify that the addition of the lifecycle block correctly ignores tag changes to avoid unnecessary updates, these tags do not affect the functionality of the resources.

Checklist for Primary Reviewer

Infrastructure

• Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

• Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
• Any dependencies introduced have been vetted and discussed

Cloud

• Oncall has been notified if this change is going in after-hours
• If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

• Any changes to the startup configuration have been documented in the README

[alismx]

This was incorrectly tagged. "${local.project}-${local.name}-${local.env}" resolves to prime-simple-report-dev3 when it should have been prime-simple-report-dev.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[rin-skylight]

🏷️ 💥 ❗

[DanielSass]

This PR also introduces lifecycle blocks to several resources to eliminate needless tag updates. The CDC is pretty much in charge of our tags and we don't use them for any meaningful purpose, we don't need to track or update the values of them.

Is the cdc tagging our resources outside of terraform / source control?

[DanielSass]

🏷️ ➡️ 🗑️

[emyl3]

LGTM!