-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add equipment uid type to bundle #6840
Conversation
backend/src/main/java/gov/cdc/usds/simplereport/api/converter/FhirConverter.java
Fixed
Show fixed
Hide fixed
cda1e81
to
af0f533
Compare
Kudos, SonarCloud Quality Gate passed! |
@@ -135,7 +135,7 @@ public class DeviceTypeSyncService { | |||
|
|||
public String extractSpecimenTypeCode(String specimenDescription) { | |||
Pattern specimenCode = Pattern.compile("^(.*?)\\^"); | |||
return extractSpecimenDetails(specimenDescription, specimenCode); | |||
return extractSpecimenDetails(specimenDescription, specimenCode).strip(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed to run a device sync to put the equipment UID type into our dev 2 db, but turns out there was an extra white space char in one of the specimen types coming from the LIVD API that was blowing up the sync (since that field requires number-only values)
Adding this here to protect against it, but lmk if we want to make this more robust / if we should follow up with RS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Device.identifier.type.coding.code.
Testing
This branch that has an extra log statement is deployed on dev2
Upload a bulk upload and observe that the identifier array has the equipment UID type included in the array.
Example CSV (DII is equipment UID type for the specified device)
Azure output (observe DII in the device json identifier)
Expand me for a long FHIR bundle