New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show duplicate results in results table #6884

Closed

BobanL wants to merge 7 commits into main from boban/fix-corrected-results

Contributor

BobanL commented Oct 30, 2023 •

edited

Loading

BACKEND PULL REQUEST

Related Issue

When a result gets corrected, both show up on the results list. In the case of marking it as "duplicated", the result still shows up.

Screenshare.-.2023-10-30.3_40_01.PM.mp4

Changes Proposed

Add a where clause that should do where testEvent.testOrder.internalId = testEvent.internalId. This should ensure getting the latest test event from a test order.

Additional Information

When trying to join result on test order and then joining on test event, only test order fields would be populated in the query.

Testing

New query being generated: https://www.diffchecker.com/zCwJxbNO/
Ensure that corrected results do not show up twice on the result table and duplicated results get crossed out.

BobanL added 3 commits

October 30, 2023 15:29


          move getDateTested to BaseTestInfo

c67fea4

testOrder needs access


          join result on test order

89a957a


          replace getTestEvent with getTestOrder when building TestResultsListItem

98a9dfb

BobanL requested review from zdeveloper and nathancrtr

October 30, 2023 19:46

BobanL changed the title ~~do not show corrected results in results~~ do not show corrected results in results table

BobanL changed the title ~~do not show corrected results in results table~~ do not show duplicate results in results table

BobanL removed request for zdeveloper and nathancrtr

October 30, 2023 21:29

BobanL added 4 commits

October 31, 2023 15:35


          move date tested back to TestEvent

498e936


          getTestEvent again instead of test order

b898f90


          put date tested into test event

b28f860


          ensure the test event is the latest one in the test order.

038aeec

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

BobanL requested a review from zdeveloper

October 31, 2023 20:16

BobanL closed this

BobanL deleted the boban/fix-corrected-results branch

November 1, 2023 19:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet