Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package names in GitHub Container Registry cleanup workflow #7135

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Update package names in GitHub Container Registry cleanup workflow #7135

merged 1 commit into from
Jan 4, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Jan 3, 2024 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • This PR updates the GitHub actions workflow for cleaning up package versions in the GitHub Container Registry (GHCR).

Testing

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx marked this pull request as ready for review January 3, 2024 21:03
@alismx alismx changed the title chore: update package names in GitHub Container Registry cleanup work… Update package names in GitHub Container Registry cleanup workflow Jan 3, 2024
@alismx alismx requested review from a team, mehansen, DanielSass, fzhao99, mpbrown and emyl3 and removed request for a team January 3, 2024 21:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

emyl3
emyl3 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this! 🔧

mpbrown
mpbrown approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alismx alismx added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit bccf6c5 Jan 4, 2024
34 checks passed
@alismx alismx deleted the alis/ghcr_cleanup_fix branch January 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen Awaiting requested review from mehansen mehansen was automatically assigned from CDCgov/simplereport-engineeringreviews

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass was automatically assigned from CDCgov/simplereport-engineeringreviews

@fzhao99 fzhao99 Awaiting requested review from fzhao99 fzhao99 was automatically assigned from CDCgov/simplereport-engineeringreviews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create GH action to clean up old docker images
3 participants
@alismx @emyl3 @mpbrown