Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor container cleaning workflow and include delay for dele… #7237

Merged
merged 5 commits into from
Feb 1, 2024
Merged

feat: Refactor container cleaning workflow and include delay for dele… #7237

merged 5 commits into from
Feb 1, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Feb 1, 2024 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Update to run more often
  • Add sleep to get around a secondary rate limit

Additional Information

  • This job was somewhat working, except we hit a secondary rate limit after the first 200 images were deleted. We still have hundreds of pages of untagged images to get through, so I thought increasing the frequency would help us burn through it.
  • This job will need to be revised after we delete the bulk of untagged images.
  • I'm open to other solutions.

Testing

@alismx alismx requested review from a team, mehansen, DanielSass and mpbrown and removed request for a team February 1, 2024 17:56
@alismx alismx marked this pull request as ready for review February 1, 2024 17:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

emyl3
emyl3 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup! 🧹

@alismx alismx added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 3e868b1 Feb 1, 2024
34 checks passed
@alismx alismx deleted the alis/ghcr-cleanup-sleep branch February 1, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen mehansen was automatically assigned from CDCgov/simplereport-engineeringreviews

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass was automatically assigned from CDCgov/simplereport-engineeringreviews

@mpbrown mpbrown Awaiting requested review from mpbrown mpbrown was automatically assigned from CDCgov/simplereport-engineeringreviews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alismx @emyl3 @fzhao99