Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test event survey data after AOE correction #7904

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Jul 11, 2024

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • After making an AOE change on a correction test card, submitting the test event survey data will now correctly store the updated AOE survey data from the test order as opposed to the old survey data from the original test event.

Additional Information

  • When the conduct test queue and test card were refactored last year, it wasn't immediately clear that we technically introduced a new feature: being able to make changes to AOE responses on a test correction. Before the test card overhaul, the AOE questions were asked in a pre-test modal and as far as we're aware, the user did not have the ability to change AOE responses on a test correction. After the overhaul, the AOE questions were moved to be on the test card directly and now accessible for the user to make changes on a test correction.

Testing

  • Deployed on dev5
  • Submit a test with some AOE responses
  • Find that test in the Results page and View Details to verify the AOE response data appears as expected
  • Start a Correct Test flow for that test result
  • On the corrected test, make some change to the AOE response
  • Go back to the Results page and View Details again to verify the AOE response has been updated

Copy link

@mpbrown mpbrown marked this pull request as ready for review July 11, 2024 17:06
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpbrown
Copy link
Collaborator Author

mpbrown commented Jul 11, 2024

Made a note in the eng sync agenda to discuss whether we need to resend any data

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpbrown mpbrown added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@mpbrown mpbrown added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 748b999 Jul 11, 2024
40 checks passed
@mpbrown mpbrown deleted the mike/7877-aoe-correction-bug branch July 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Updating the AoE on a correction does not update the result
4 participants