Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rimraf from 5.0.7 to 6.0.1 in /ops/services/app_functions/report_stream_batched_publisher/functions #7990

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Bump rimraf from 5.0.7 to 6.0.1 in /ops/services/app_functions/report_stream_batched_publisher/functions #7990

merged 5 commits into from
Aug 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 4, 2024 •
edited
Loading

Bumps rimraf from 5.0.7 to 6.0.1.

Changelog

Sourced from rimraf's changelog.

6.0

  • Drop support for nodes before v20
  • Add --version to CLI

5.0

  • No default export, only named exports

4.4

  • Provide Dirent or Stats object as second argument to filter

4.3

  • Return boolean indicating whether the path was fully removed
  • Add filter option
  • bin: add --verbose, -v to print files as they are deleted
  • bin: add --no-verbose, -V to not print files as they are deleted
  • bin: add -i --interactive to be prompted on each deletion
  • bin: add -I --no-interactive to not be prompted on each deletion
  • 4.3.1 Fixed inappropriately following symbolic links to directories

v4.2

  • Brought back glob support, using the new and improved glob v9

v4.1

  • Improved hybrid module with no need to look at the .default dangly bit. .default preserved as a reference to rimraf for compatibility with anyone who came to rely on it in v4.0.
  • Accept and ignore -rf and -fr arguments to the bin.

v4.0

  • Remove glob dependency entirely. This library now only accepts actual file and folder names to delete.
  • Accept array of paths or single path.
  • Windows performance and reliability improved.
  • All strategies separated into explicitly exported methods.
  • Drop support for Node.js below version 14
  • rewrite in TypeScript
  • ship CJS/ESM hybrid module
  • Error on unknown arguments to the bin. (Previously they were silently ignored.)

v3.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 4, 2024
@dependabot dependabot bot requested review from a team, mehansen, DanielSass and emyl3 and removed request for a team August 4, 2024 15:17
@github-actions github-actions bot mentioned this pull request Aug 4, 2024
Closed
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ops/services/app_functions/report_stream_batched_publisher/functions/rimraf-6.0.1 branch from 68614b8 to 2d476e4 Compare August 9, 2024 16:25
@mpbrown
Copy link
Collaborator

mpbrown commented Aug 13, 2024

@dependabot rebase

@dependabot
Bump rimraf
fcb2e03 
Bumps [rimraf](https://github.com/isaacs/rimraf) from 5.0.7 to 6.0.1.
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v5.0.7...v6.0.1)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ops/services/app_functions/report_stream_batched_publisher/functions/rimraf-6.0.1 branch from 2d476e4 to fcb2e03 Compare August 13, 2024 01:58
@emyl3
Copy link
Collaborator

emyl3 commented Aug 16, 2024

@dependabot rebase

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 16, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@emyl3 emyl3 self-assigned this Aug 16, 2024
@emyl3 emyl3 force-pushed the dependabot/npm_and_yarn/ops/services/app_functions/report_stream_batched_publisher/functions/rimraf-6.0.1 branch 2 times, most recently from 3c628d3 to fcb2e03 Compare August 16, 2024 18:14
@emyl3 emyl3 force-pushed the dependabot/npm_and_yarn/ops/services/app_functions/report_stream_batched_publisher/functions/rimraf-6.0.1 branch 2 times, most recently from 546e1ae to 90b518a Compare August 16, 2024 21:46
emyl3
emyl3 reviewed Aug 19, 2024
View reviewed changes
.github/actions/build-reportstream-functions/action.yml
@@ -7,6 +7,9 @@ inputs:
runs:
using: composite
steps:
- uses: actions/setup-node@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to add this step to specify the node version otherwise it was running on node 18 and erroring

emyl3
emyl3 reviewed Aug 19, 2024
View reviewed changes
.github/workflows/test.yml
@@ -99,6 +99,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with the tests as well

@emyl3
Copy link
Collaborator

emyl3 commented Aug 19, 2024

@shanice-skylight and @alismx made some changes to the github action and workflow files for the function app to use node 20 -- otherwise it was using v18 and failing (Added you both to review in case there can be improvements with my changes!) thank you!!

@emyl3
Copy link
Collaborator

emyl3 commented Aug 19, 2024

Deployed and tested on dev6 and the message was added to the queue correctly. Also ran yarn clean locally and worked without any errors.

@emyl3 emyl3 requested a review from mpbrown August 19, 2024 14:53
@emyl3 emyl3 assigned fzhao99 and unassigned emyl3 Aug 22, 2024
fzhao99
fzhao99 previously approved these changes Aug 22, 2024
View reviewed changes
@mehansen
Merge branch 'main' into dependabot/npm_and_yarn/ops/services/app_fun…
bb68812 
…ctions/report_stream_batched_publisher/functions/rimraf-6.0.1
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mehansen
mehansen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested rimraf locally ✅
submitted a single-entry test and saw it got processed by both Covid pipeline and UP functions ✅

@fzhao99 fzhao99 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 5126a1b Aug 29, 2024
38 checks passed
@fzhao99 fzhao99 deleted the dependabot/npm_and_yarn/ops/services/app_functions/report_stream_batched_publisher/functions/rimraf-6.0.1 branch August 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 left review comments

@fzhao99 fzhao99 fzhao99 approved these changes

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass was automatically assigned from CDCgov/simplereport-engineeringreviews

@alismx alismx Awaiting requested review from alismx

@shanice-skylight shanice-skylight Awaiting requested review from shanice-skylight

@mpbrown mpbrown Awaiting requested review from mpbrown

Assignees

@fzhao99 fzhao99

Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpbrown @emyl3 @mehansen @fzhao99