Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HIV bulk upload link from admin page #8050

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

bobbywells52
Copy link
Collaborator

@bobbywells52 bobbywells52 commented Aug 20, 2024

Backend/FRONTEND PULL REQUEST

Related Issue

Resolves #7951

Changes Proposed

  • Remove the /upload/hiv-results endpoint
  • Remove the beta link to the HIV upload form on the admin support page
  • Remove the corresponding HIV upload form
  • Delete or refactor obsolete tests

Additional Information

  • As it was outside the scope of the ticket, I did not remove the bulkHivUploadEnabled flag from the code base but my work on this ticket makes me wonder if we need the flag at all anymore.

Testing

Live for review on dev6, reviewer should confirm the following:

  • that/admin/hiv-csv-upload is no longer a valid route.
  • that the link to the HIV Bulk Upload Beta is no longer on the admin support page
  • that you can no longer hit the /upload/hiv-results endpoint

@bobbywells52 bobbywells52 changed the title Bobby/remove bulk upload link Remove HIV bulk upload link from admin page Aug 20, 2024
@bobbywells52 bobbywells52 marked this pull request as ready for review August 20, 2024 21:28
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about one more thing to remove! Nice cleanup, Bobby! 🧹

@bobbywells52 bobbywells52 requested a review from emyl3 August 21, 2024 15:38
Copy link

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbywells52 bobbywells52 added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 1259bad Aug 21, 2024
36 checks passed
@bobbywells52 bobbywells52 deleted the bobby/removeBulkUploadLink branch August 21, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up HIV bulk upload beta from support admin dashboard
3 participants