Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gonorrhea to SupportedDiseases #8319

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add Gonorrhea to SupportedDiseases #8319

merged 1 commit into from
Nov 25, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Nov 25, 2024 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds Gonorrhea to the SupportedDiseases table

Testing

  • Deployed to dev5
  • Gonorrhea is available as an option for support admins adding a new test device (note that this support admin device form is not hidden behind a feature flag for gonorrhea)
    image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpbrown mpbrown enabled auto-merge November 25, 2024 16:37
bobbywells52
bobbywells52 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emyl3
emyl3 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and rolled back gonorrhea locally! works as expected! thank you mike!

@mpbrown mpbrown added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 593c56c Nov 25, 2024
38 of 39 checks passed
@mpbrown mpbrown deleted the mike/7434-gonorrhea-supported-disease branch November 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpbrown @emyl3 @bobbywells52