Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gonorrhea support to test card #8321

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Nov 25, 2024

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds support for Gonorrhea to the test card
  • Converts the HepatitisCAoeForm component into STIGenericAoeForm that receives the disease specific data as props. This component is used for Hep C AOE and Gonorrhea AOE

Additional Information

  • This also adds support for Gonorrhea on the dashboard and (most) of the result page besides result specific guidance and some conditional logic for showing genders of sexual partners on view details
  • Gonorrhea symptoms list may not necessarily be final (see this Slack thread)

Testing

  • Deployed on dev5
  • Gonorrhea test device has been created on Boban's Org and boban 1 facility

Screenshots

image

@mpbrown mpbrown force-pushed the mike/7434-gonorrhea-test-card branch from d59ddd4 to 4c8492d Compare November 26, 2024 16:58
@mpbrown mpbrown changed the title Mike/7434 gonorrhea test card Add Gonorrhea support to test card Nov 26, 2024
@mpbrown mpbrown marked this pull request as ready for review November 27, 2024 20:05
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for renaming the shared component to STIGenericAOEForm! 🎉

(x) => x.supportedDisease.name === MULTIPLEX_DISEASES.GONORRHEA
).length === 1
) {
return resultHasPositive ? AOEFormOption.GONORRHEA : AOEFormOption.NONE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tangentially related to this change: do you think we need to make it known somewhere (e.g. warn Jayna, add a validation to add device page?) that we can't support devices that test for multiple STIs currently without changing this part of the code? it's technically possible to create that device in SR so I can see it happening where Jayna creates a ticket to add a device, we refine it and don't think about it, and then end up creating it and the AOE don't work properly. but maybe I'm being paranoid about my memory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good point, we should make sure everyone on the team knows we can't support multi-STI devices yet. I don't think we necessarily need to add separate validation since the multiple device test card redesign is one of the big upcoming features that will likely require us to deal with those AOE questions in a more comprehensive manner

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree! seems like this won't be the case for long

}

export const HepatitisCAoeForm = ({
export const STIGenericAOEForm = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name did confuse me a little because I thought we'd be using it for all the STIs instead of just 2 of them. but I don't have a better suggestion 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ideally we could have a children slot for this component so syphilis AOE form can extend it simply by passing in the component for the syphilis history question but there's a risk of the form management getting harder to follow and it seems like AOE questions will get a large revamp once we start doing multiple devices per test card

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a risk of the form management getting harder to follow and it seems like AOE questions will get a large revamp once we start doing multiple devices per test card

also agree!

@mpbrown mpbrown added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@mpbrown mpbrown added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 4cc513c Dec 2, 2024
47 of 48 checks passed
@mpbrown mpbrown deleted the mike/7434-gonorrhea-test-card branch December 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test card supports Gonorrhea test results
3 participants