-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gonorrhea support to test card #8321
Conversation
d59ddd4
to
4c8492d
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for renaming the shared component to STIGenericAOEForm
! 🎉
(x) => x.supportedDisease.name === MULTIPLEX_DISEASES.GONORRHEA | ||
).length === 1 | ||
) { | ||
return resultHasPositive ? AOEFormOption.GONORRHEA : AOEFormOption.NONE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tangentially related to this change: do you think we need to make it known somewhere (e.g. warn Jayna, add a validation to add device page?) that we can't support devices that test for multiple STIs currently without changing this part of the code? it's technically possible to create that device in SR so I can see it happening where Jayna creates a ticket to add a device, we refine it and don't think about it, and then end up creating it and the AOE don't work properly. but maybe I'm being paranoid about my memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good point, we should make sure everyone on the team knows we can't support multi-STI devices yet. I don't think we necessarily need to add separate validation since the multiple device test card redesign is one of the big upcoming features that will likely require us to deal with those AOE questions in a more comprehensive manner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree! seems like this won't be the case for long
} | ||
|
||
export const HepatitisCAoeForm = ({ | ||
export const STIGenericAOEForm = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name did confuse me a little because I thought we'd be using it for all the STIs instead of just 2 of them. but I don't have a better suggestion 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ideally we could have a children
slot for this component so syphilis AOE form can extend it simply by passing in the component for the syphilis history question but there's a risk of the form management getting harder to follow and it seems like AOE questions will get a large revamp once we start doing multiple devices per test card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a risk of the form management getting harder to follow and it seems like AOE questions will get a large revamp once we start doing multiple devices per test card
also agree!
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
HepatitisCAoeForm
component intoSTIGenericAoeForm
that receives the disease specific data as props. This component is used for Hep C AOE and Gonorrhea AOEAdditional Information
Testing
Screenshots